Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【API】Add sign and tanh api #26357

Merged
merged 2 commits into from
Aug 22, 2020
Merged

【API】Add sign and tanh api #26357

merged 2 commits into from
Aug 22, 2020

Conversation

wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Aug 17, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  1. Add paddle.sign. Deprecated paddle.fluid.layers.sign.
  2. Add paddle.tanh, alias paddle.nn.functional.tanh. Add class paddle.nn.Tanh.

Doc PR and preview PaddlePaddle/docs#2402
English doc preview:
image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 17, 2020 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@wangxicoding wangxicoding mentioned this pull request Aug 17, 2020
Merged
@wangxicoding wangxicoding changed the title refine 2.0 sign api sign 2.0api: add name args, refine doc Aug 18, 2020
@wangxicoding wangxicoding changed the title sign 2.0api: add name args, refine doc refine sign and tanh api Aug 18, 2020
@wangxicoding wangxicoding force-pushed the refine_sign branch 2 times, most recently from 480bf2b to 476b143 Compare August 20, 2020 12:40
ForFishes
ForFishes previously approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangxicoding wangxicoding changed the title refine sign and tanh api 【API】refine sign and tanh api Aug 21, 2020
@wangxicoding wangxicoding changed the title 【API】refine sign and tanh api 【API】Add sign and tanh api Aug 21, 2020
swtkiwi
swtkiwi approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
will have followup pr

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit ed102ea into PaddlePaddle:develop Aug 22, 2020
@wangxicoding wangxicoding deleted the refine_sign branch December 2, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@swtkiwi swtkiwi swtkiwi approved these changes

@ForFishes ForFishes ForFishes approved these changes

@jzhang533 jzhang533 jzhang533 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangxicoding @jzhang533 @ForFishes @swtkiwi @XiaoguangHu01