-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【2.0 API】Enhance affine grid operator #26385
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a949914
Enhance affine grid operator:
wanghaoshuang d91f592
Move new affine_grid api to functional
wanghaoshuang 75d7d06
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
wanghaoshuang 55a26f1
Add CUDA kernel for affine_grid.
wanghaoshuang de31410
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
wanghaoshuang dd46209
Add more unitest for grid sample API
wanghaoshuang 1057b18
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
wanghaoshuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* Copyright (c) 2010 PaddlePaddle Authors. All Rights Reserved. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. */ | ||
|
||
#include "paddle/fluid/framework/op_registry.h" | ||
#include "paddle/fluid/operators/affine_grid_op.h" | ||
|
||
namespace paddle { | ||
namespace operators { | ||
|
||
using Tensor = framework::Tensor; | ||
|
||
template <typename T> | ||
__global__ void LinspaceKernel(T start, T step, int64_t size, T* out) { | ||
CUDA_KERNEL_LOOP(index, size) { out[index] = start + step * index; } | ||
} | ||
|
||
template <typename T> | ||
struct Linspace<paddle::platform::CUDADeviceContext, T> { | ||
void operator()(T start, T end, int count, bool align_corners, | ||
framework::Tensor* numbers, | ||
const framework::ExecutionContext& ctx) { | ||
T* number_data = numbers->mutable_data<T>({count}, ctx.GetPlace()); | ||
T slice = (end - start) / (T)(count - 1); | ||
if (!align_corners) { | ||
slice = (end - start) / (T)count; | ||
start *= (T)(count - 1) / (T)count; | ||
} | ||
auto stream = ctx.cuda_device_context().stream(); | ||
int block = 512; | ||
int grid = (count + block - 1) / block; | ||
LinspaceKernel<T><<<grid, block, 0, stream>>>(start, slice, count, | ||
number_data); | ||
} | ||
}; | ||
|
||
} // namespace operators | ||
} // namespace paddle | ||
|
||
namespace ops = paddle::operators; | ||
REGISTER_OP_CUDA_KERNEL( | ||
affine_grid, | ||
ops::AffineGridOpKernel<paddle::platform::CUDADeviceContext, float>, | ||
ops::AffineGridOpKernel<paddle::platform::CUDADeviceContext, double>); | ||
REGISTER_OP_CUDA_KERNEL( | ||
affine_grid_grad, | ||
ops::AffineGridGradOpKernel<paddle::platform::CUDADeviceContext, float>, | ||
ops::AffineGridGradOpKernel<paddle::platform::CUDADeviceContext, double>); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
python/paddle/fluid/tests/unittests/test_affine_grid_function.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import numpy as np | ||
from paddle import fluid, nn | ||
import paddle.fluid.dygraph as dg | ||
import paddle.nn.functional as F | ||
import paddle.fluid.initializer as I | ||
import unittest | ||
|
||
|
||
class AffineGridTestCase(unittest.TestCase): | ||
def __init__(self, | ||
methodName='runTest', | ||
theta_shape=(20, 2, 3), | ||
output_shape=[20, 2, 5, 7], | ||
align_corners=True, | ||
dtype="float32"): | ||
super(AffineGridTestCase, self).__init__(methodName) | ||
|
||
self.theta_shape = theta_shape | ||
self.output_shape = output_shape | ||
self.align_corners = align_corners | ||
self.dtype = dtype | ||
|
||
def setUp(self): | ||
self.theta = np.random.randn(*(self.theta_shape)).astype(self.dtype) | ||
|
||
def fluid_layer(self, place): | ||
# align_corners = True | ||
main = fluid.Program() | ||
start = fluid.Program() | ||
with fluid.unique_name.guard(): | ||
with fluid.program_guard(main, start): | ||
theta_var = fluid.data( | ||
"input", self.theta_shape, dtype=self.dtype) | ||
y_var = fluid.layers.affine_grid(theta_var, self.output_shape) | ||
feed_dict = {"input": self.theta} | ||
exe = fluid.Executor(place) | ||
exe.run(start) | ||
y_np, = exe.run(main, feed=feed_dict, fetch_list=[y_var]) | ||
return y_np | ||
|
||
def functional(self, place): | ||
main = fluid.Program() | ||
start = fluid.Program() | ||
with fluid.unique_name.guard(): | ||
with fluid.program_guard(main, start): | ||
theta_var = fluid.data( | ||
"input", self.theta_shape, dtype=self.dtype) | ||
y_var = F.affine_grid( | ||
theta_var, | ||
self.output_shape, | ||
align_corners=self.align_corners) | ||
feed_dict = {"input": self.theta} | ||
exe = fluid.Executor(place) | ||
exe.run(start) | ||
y_np, = exe.run(main, feed=feed_dict, fetch_list=[y_var]) | ||
return y_np | ||
|
||
def paddle_dygraph_layer(self): | ||
theta_var = dg.to_variable(self.theta) | ||
y_var = F.affine_grid( | ||
theta_var, self.output_shape, align_corners=self.align_corners) | ||
y_np = y_var.numpy() | ||
return y_np | ||
|
||
def _test_equivalence(self, place): | ||
place = fluid.CPUPlace() | ||
result1 = self.fluid_layer(place) | ||
result2 = self.functional(place) | ||
with dg.guard(place): | ||
result3 = self.paddle_dygraph_layer() | ||
if self.align_corners: | ||
np.testing.assert_array_almost_equal(result1, result2) | ||
np.testing.assert_array_almost_equal(result2, result3) | ||
|
||
def runTest(self): | ||
place = fluid.CPUPlace() | ||
self._test_equivalence(place) | ||
|
||
if fluid.core.is_compiled_with_cuda(): | ||
place = fluid.CUDAPlace(0) | ||
self._test_equivalence(place) | ||
|
||
|
||
class AffineGridErrorTestCase(AffineGridTestCase): | ||
def runTest(self): | ||
place = fluid.CPUPlace() | ||
with dg.guard(place): | ||
with self.assertRaises(ValueError): | ||
self.paddle_dygraph_layer() | ||
|
||
|
||
def add_cases(suite): | ||
suite.addTest(AffineGridTestCase(methodName='runTest')) | ||
suite.addTest(AffineGridTestCase(methodName='runTest', align_corners=True)) | ||
|
||
suite.addTest(AffineGridTestCase(methodName='runTest', align_corners=False)) | ||
|
||
suite.addTest( | ||
AffineGridTestCase( | ||
methodName='runTest', | ||
theta_shape=(20, 2, 3), | ||
output_shape=[20, 1, 7, 7], | ||
align_corners=True)) | ||
|
||
|
||
def add_error_cases(suite): | ||
suite.addTest( | ||
AffineGridErrorTestCase( | ||
methodName='runTest', output_shape="not_valid")) | ||
|
||
|
||
def load_tests(loader, standard_tests, pattern): | ||
suite = unittest.TestSuite() | ||
add_cases(suite) | ||
add_error_cases(suite) | ||
return suite | ||
|
||
|
||
if __name__ == '__main__': | ||
unittest.main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the cuda version mostly reused the eigen implementation? some preliminary benchmark would be nice if time permits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added CUDA kernel.
I will give some performance benchmark on CUDNN version and CUDA kernel version in the future.
Currently, it will use CUDNN kernel when align_corners is true and use CUDA kernel when align_corners is false.