improve unique op #26537
Merged
improve unique op #26537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
previously approved these changes
Aug 24, 2020
zhangting2020
dismissed stale reviews from zhiqiu and wangchaochaohu
via
36ebf51
wangchaochaohu
approved these changes
Aug 24, 2020
zhiqiu
approved these changes
Aug 24, 2020
XiaoguangHu01
approved these changes
Aug 24, 2020
| np_inverse = inverse.numpy() # [1 2 2 0 3 2] | ||
| np_counts = counts.numpy() # [1 1 3 1] | ||
|
|
||
| x_data = np.array([[2, 1, 3], [3, 0, 1], [2, 1, 3]]) |
There was a problem hiding this comment.
x = paddle.to_tensor(x_data)
There was a problem hiding this comment.
文档问题我另提一个PR进行修改
| dtype=x.dtype, stop_gradient=True) | ||
| inverse = helper.create_variable_for_type_inference( | ||
| dtype=core.VarDesc.VarType.INT64, stop_gradient=True) | ||
| outputs = {"Out": out, "Index": inverse} |
There was a problem hiding this comment.
Index： inverse 名称不对应，看起来比较奇怪，有什么特别的原因么？
There was a problem hiding this comment.
新版本的unique API可返回4个输出：out，indices、inverse、counts，
旧版本的unique API返回2个输出：out，index（实际是inverse，虽然其值也是索引）
由于旧版本的OP将输出 Inverse命名为了Index。为了兼容性，名字无法修改，因此在OpMaker中专门做了说明，详见unique.cc 103行：
AddOutput("Index", "Equivalent to inverse in numpy.unique, ..."
实际这里的Index对应了numpy.unique的输出unique_inverse。
|
|
||
| helper = LayerHelper('unique', **locals()) | ||
| attrs = { | ||
| 'dtype': int(core.VarDesc.VarType.INT32), |
There was a problem hiding this comment.
numpy的返回值默认是INT64。
或者增加dtype参数，默认值使用'int64'
There was a problem hiding this comment.
- fluid下旧的unique接口中有dtype参数：
paddle.fluid.layers.unique(x, dtype='int32'), API链接。在c++的OpMaker中该参数是必选参数。 - 在2.0 beta版本中unique API去除了
dtype参数，为了保证OP的兼容性，OpMaker中此属性不能删除，因此在tensor下新增的unique API不得不设置dtype属性（因为是必选参数），但是实际不会用到，所以这里设置为int32其实并不会使用。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimizationPR changes
OPsDescribe
improve unique op