[2.0 API] add SyncBatchNorm.convert_sync_batch_norm #26688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
PR标题有点太简单了。 |
ceci3
changed the title
jzhang533
reviewed
Aug 26, 2020
willthefrog
reviewed
Aug 26, 2020
ceci3
requested review from
frankwhzhang,
willthefrog,
jzhang533 and
wanghaoshuang
willthefrog
requested changes
Aug 27, 2020
| default_initializer=Constant(1.0)) | ||
| self.weight.stop_gradient = (self._weight_attr is False) or ( | ||
| self._weight_attr and self._weight_attr.learning_rate == 0.) | ||
| if weight_attr == False: |
There was a problem hiding this comment.
False -> None
None != False
看起来这个if-else逻辑跟下面这种写法等价
self.weight = self.create_parameter(
attr=weight_attr,
shape=param_shape,
default_initializer=Constant(1.0))
self.weight.stop_gradient = (weight_attr == None) or (weight_attr.learning_rate == 0.)
There was a problem hiding this comment.
如果weight_attr是False的话，self.weight就会是None，设置stop_gradient这一步就会报错..
| attr=self._bias_attr, shape=param_shape, is_bias=True) | ||
| self.bias.stop_gradient = (self._bias_attr is False) or ( | ||
| self._bias_attr and self._bias_attr.learning_rate == 0.) | ||
| if bias_attr == False: |
| layer._bias_attr, layer._data_format, | ||
| layer._name) | ||
|
|
||
| if layer._weight_attr != False and layer._bias_attr != False: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
add convert_sync_batch_norm for SyncBatchNorm to convert standard bn to syncbn
fix batch norm when weight_attr=False or bias_attr=False