fix dropout bug in backward when input is 1d tensor #26837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
iclementine
reviewed
Sep 1, 2020
| .format(len(input_shape), max(drop_axes))) | ||
| if len(drop_axes) > len(input_shape): | ||
| raise ValueError( | ||
| "length of axis should not greater than dimensions of x:{}, but get length of drop axes: {}". | ||
| "length of axis should not greater than dimensions of x:{}, but get length of axis: {}". |
iclementine
reviewed
Sep 1, 2020
| if max(drop_axes) > len(input_shape) - 1: | ||
| raise ValueError("axis value should less than dimensions of x:{}, but get drop_axes value:{} " \ | ||
| if min(drop_axes) < 0 or max(drop_axes) > len(input_shape) - 1: | ||
| raise ValueError("axis value should greater equal than 0 and less than dimensions of x:{}, but get axis value:{} " \ |
iclementine
reviewed
Sep 1, 2020
| auto dY = EigenMatrix<T>::Reshape(*grad_y, 1); | ||
| auto M = EigenVector<uint8_t>::Flatten(*mask); | ||
| auto dX = EigenVector<T>::Flatten(*grad_x); | ||
| auto dY = EigenVector<T>::Flatten(*grad_y); |
There was a problem hiding this comment.
是否添加输入是 1D 的单测以确保其正确性？以往这个问题没有被测试出来，是因为从没有测试过 1D case？
iclementine
reviewed
Sep 2, 2020
| class TestDropoutOpInput1d(OpTest): | ||
| def setUp(self): | ||
| self.op_type = "dropout" | ||
| self.inputs = {'X': np.random.random((2000)).astype("float32")} |
huangjun12
added a commit
to huangjun12/Paddle
that referenced
this pull request
Sep 3, 2020
* fix dropout bug in backward when input is 1d tensor, test=develop * add test case and refine error message, test=develop * refine error message, test=develop
iclementine
pushed a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
fix dropout op bug in backward when input is 1d tensor