stride pooling for max and average layer #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
changed the title
lcy-seso
reviewed
Jul 5, 2017
paddle/gserver/layers/MaxLayer.h
Outdated
| @@ -26,6 +26,11 @@ namespace paddle { | |||
| * If SequenceLevel = kNonSeq: | |||
| * Output: output size is the number of input sequences (NOT input instances) | |||
| * output[i] = max_{for each instance in this sequence}{input[i]} | |||
| * If stride_ > 0: | |||
| * Output: a shorten sequence. The operation of getting max instance of a | |||
| * sequence is independently performed on every slice of the input | |||
There was a problem hiding this comment.
- “getting max instance of a sequence” 这个表述令人困惑。
- Stride is the step size by which we slide a window upon the input sequence, and the pooling operation is then applied to each interval independently.
There was a problem hiding this comment.
Done. And update the comments in SequencePoolLayer.h, AverageLayer.h and SequenceLastInstanceLayer.h at the same time.
| @@ -1112,6 +1118,8 @@ def pooling_layer(input, | |||
| :param pooling_type: Type of pooling, MaxPooling(default), AvgPooling, | |||
| SumPooling, SquareRootNPooling. | |||
| :type pooling_type: BasePoolingType|None | |||
| :param stride: window size. | |||
There was a problem hiding this comment.
stride --> the step size between successive pooling regions.
There was a problem hiding this comment.
Done, and update the comments in last_seq and first_seq at the same time.
| If stride > 0, this layer slides a window whose size is determined by stride, | ||
| and return the pooling value of the window as the output. Thus, a long sequence | ||
| will be shorten. Note that for sequence with sub-sequence, the default value | ||
| of stride is -1. |
There was a problem hiding this comment.
the parameter stride specifies the intervals at which to apply the pooling operation.
luotao1
commented
Jul 5, 2017
| If stride > 0, this layer slides a window whose size is determined by stride, | ||
| and return the pooling value of the window as the output. Thus, a long sequence | ||
| will be shorten. Note that for sequence with sub-sequence, the default value | ||
| of stride is -1. |
| @@ -1112,6 +1118,8 @@ def pooling_layer(input, | |||
| :param pooling_type: Type of pooling, MaxPooling(default), AvgPooling, | |||
| SumPooling, SquareRootNPooling. | |||
| :type pooling_type: BasePoolingType|None | |||
| :param stride: window size. | |||
There was a problem hiding this comment.
Done, and update the comments in last_seq and first_seq at the same time.
paddle/gserver/layers/MaxLayer.h
Outdated
| @@ -26,6 +26,11 @@ namespace paddle { | |||
| * If SequenceLevel = kNonSeq: | |||
| * Output: output size is the number of input sequences (NOT input instances) | |||
| * output[i] = max_{for each instance in this sequence}{input[i]} | |||
| * If stride_ > 0: | |||
| * Output: a shorten sequence. The operation of getting max instance of a | |||
| * sequence is independently performed on every slice of the input | |||
There was a problem hiding this comment.
Done. And update the comments in SequencePoolLayer.h, AverageLayer.h and SequenceLastInstanceLayer.h at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1608.
finish feature of "Sequence Pooling with Stride".