Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _check_values_dtype_in_probs method in Distribution class #27046

Conversation

pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Sep 4, 2020

PR types

Others

PR changes

APIs

Describe

_check_values_dtypes_in_probs(param, value) method in Distribution class is used to ensure dtype of param and value are consistent. (refer to PR #26767)
If in_dygraph_mode and value.dtype == param.dtype, it doesn't have return value in dygraph mode. And it has to run static mode again. This PR adds return value in dygraph mode.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 4, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit f0b2631 into PaddlePaddle:develop Sep 7, 2020
@pangyoki pangyoki mentioned this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants