API(lstm_unit, lstmp, sequence_mask, sequence_enumerate, sequence_conv) error message enhancement #27572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstmp error message enhancement. sequence_conv error message enhencement. sequence_enumerate error message enhencement. sequence_mask error message enhencement.
… yxp0925 Merge branch 'develop'.
|
|
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
… yxp0925 Merge branch 'develop'.
guoshengCS
reviewed
Sep 30, 2020
| @@ -44,7 +44,9 @@ class SequenceEnumerateOpMaker : public framework::OpProtoAndCheckerMaker { | |||
| AddAttr<int>("win_size", "(int) The enumerate sequence window size.") | |||
| .AddCustomChecker([](const int& win_size) { | |||
| PADDLE_ENFORCE(win_size >= 2, | |||
| "The window size should be not less than 2."); | |||
| platform::errors::InvalidArgument( | |||
There was a problem hiding this comment.
这里的PADDLE_ENFORCE还请使用PADDLE_ENFORCE_EQ这种
| PADDLE_ENFORCE(v < 0 || v >= 1, | ||
| "Attr(maxlen) must be less than 0 or larger than 1"); | ||
| PADDLE_ENFORCE( | ||
| v < 0 || v >= 1, |
There was a problem hiding this comment.
这里的PADDLE_ENFORCE还请使用PADDLE_ENFORCE_EQ这种
guoshengCS
previously approved these changes
Sep 30, 2020
guoshengCS
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
API(lstm_unit, lstmp, sequence_mask, sequence_enumerate, sequence_conv) error message enhancement.
代码示例：
报错预览：