Polish jit.save/load design & remove paddle.SaveLoadConfig #27623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… saveload/remove_save_load_config
chenwhql
commented
Oct 9, 2020
| (1) model_filename (string): The inference model file name of the paddle 1.x ``save_inference_model`` | ||
| save format. Default file name is :code:`__model__` . | ||
| (2) params_filename (string): The persistable variables file name of the paddle 1.x ``save_inference_model`` | ||
| save format. No default file name, save variables separately by default. |
There was a problem hiding this comment.
we don't recommend users to use keep_name_table, only keep it for debuging, so don't write its doc.
chenwhql
requested review from
Aurelius84,
zhhsplendid,
phlrain,
jzhang533,
qingqing01,
liym27,
XiaoguangHu01,
raindrops2sea,
guoshengCS,
Shixiaowei02,
saxon-zh and
wzzju
Shixiaowei02
approved these changes
Oct 10, 2020
raindrops2sea
approved these changes
Oct 11, 2020
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
…dle#27623) * replace config by kwargs * change save path form dir to prefix * fix failed unittests * revert unittest name change * polish en docs * add more tests for coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
一、PR主要修改
根据预测接口paddle.static.save/load_inference_model的升级评审结论，对2.0主推的save/load接口进行了如下更改：
paddle.SaveLoadConfig，对于paddle.jit.save/load, paddle.load改为使用**kwargs作为兼容参数paddle.jit.save/load的路径参数model_path改为path，使其更加简洁并与paddle.save/load保持一致paddle.jit.save/load参数path含义，原含义为【存储预测模型的目录】，更改后为【存储预测模型相关文件的前缀】二、2.0 Save/Load全局概览
本次升级的主要目的是统一paddle各存储接口存储结果的组织形式，具体地，统一了paddle框架中save接口在"存储得到多个结果"时的文件组织方式，由原先【增加后缀】与【创建目录】共存的方式，改为统一使用【增加paddle标准后缀】的方式。
具体变化见下图：
图1. paddle 2.0 save结果形式的合理化与简化
图2. paddle 2.0 save结果整体变化表
三、TODO事项
paddle.static.save/load_inference_model的升级评审在9.28才完成，时间较为仓促。
但本次升级涉及的改动比较大，为了避免2.0正式版和2.0-RC在主推save/load接口使用上存在不兼容问题，假期内加班完成了paddle主repo中的接口改动，该PR的工作需要争取在2.0-RC切分支之前合入，剩余关联的辅助工作适当延后安排，具体包括：
paddle.jit.save/load, paddle.load, paddle.SaveLoadConfig的中文文档的对应修改paddle.jit.save/load, paddle.load在处理各个场景时的报错提示更加友好完善四、英文文档预览