Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api for ErrorClipByValue, code demo of clip_by_norm. test=develop #27654

Merged
merged 13 commits into from
Sep 30, 2020
Merged

Fix api for ErrorClipByValue, code demo of clip_by_norm. test=develop #27654

merged 13 commits into from
Sep 30, 2020

Conversation

ysh329
Copy link
Contributor

@ysh329 ysh329 commented Sep 28, 2020

PR types

Others

PR changes

APIs

Describe

Fix api for ErrorClipByValue

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ysh329 ysh329 changed the title Fix api for ErrorClipByValue. test=develop Fix api for ErrorClipByValue, code demo of clip_by_norm. test=develop Sep 28, 2020
jzhang533
jzhang533 previously approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jzhang533
jzhang533 previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jzhang533
jzhang533 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ysh329 ysh329 merged commit 9cd8648 into PaddlePaddle:develop Sep 30, 2020
@ysh329 ysh329 deleted the fix-error-clip-by-value branch September 30, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysh329 @jzhang533 @tianshuo78520a