Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine APIs: brelu, hardsigmoid, hardswish, maxout #27658

Merged
merged 13 commits into from
Oct 10, 2020
Merged

refine APIs: brelu, hardsigmoid, hardswish, maxout #27658

merged 13 commits into from
Oct 10, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Sep 28, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  • remove brelu in paddle2.0
  • hard_sigmoid -> hardsigmoid/Hardsigmoid
  • hard_swish -> hardswish/Hardswish
  • maxout -> maxout/Maxout

image
image
image
image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhupengyang zhupengyang changed the title refine APIs: brelu, hard_sigmoid refine APIs: brelu, hardsigmoid, hardswish, maxout Sep 28, 2020
hong19860320
hong19860320 previously approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit previously approved these changes Sep 30, 2020
View reviewed changes
@PaddlePaddle PaddlePaddle locked as off-topic and limited conversation to collaborators Sep 30, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 30, 2020
TCChenlong
TCChenlong previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hong19860320
hong19860320 approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 0025e0d into PaddlePaddle:develop Oct 10, 2020
@zhupengyang zhupengyang deleted the brelu branch October 10, 2020 07:50
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@zhupengyang @chen-zhiyu
refine APIs: brelu, hardsigmoid, hardswish, maxout (PaddlePaddle#27658)
72fa0d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@hong19860320 hong19860320 hong19860320 approved these changes

@lanxianghit lanxianghit lanxianghit left review comments

@zhiqiu zhiqiu Awaiting requested review from zhiqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhupengyang @hong19860320 @TCChenlong @lanxianghit