fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

zhwesky2010 · 2020-09-28T12:03:32Z

PR types

New features

PR changes

APIs

Describe

paddle-bot-old · 2020-09-28T12:03:38Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

… develop

XiaoguangHu01

LGTM

TCChenlong · 2020-10-12T04:45:49Z

python/paddle/optimizer/optimizer.py

                paddle.disable_static()
                emb = paddle.nn.Embedding(10, 10)
                adam = paddle.optimizer.Adam(0.001, parameters = emb.parameters())
                lr = adam.get_lr()
                print(lr) # 0.001

-                # example2: PiecewiseLR is used, return the step learning rate
+                # example2: PiecewiseDecay is used, return the step learning rate
                paddle.disable_static()


这行可以删除

TCChenlong · 2020-10-12T04:46:01Z

python/paddle/optimizer/optimizer.py

@@ -370,14 +372,14 @@ def get_lr(self):

                import numpy as np
                import paddle
-                # example1: _LRScheduler is not used, return value is all the same
+                # example1: LRScheduler is not used, return value is all the same
                paddle.disable_static()


这行可以删除

python/paddle/optimizer/lr.py

@@ -156,31 +213,29 @@ class NoamLR(_LRScheduler):
        verbose (bool, optional): If ``True``, prints a message to stdout for each update. Default: ``False`` .

    Returns:
-        ``NoamLR`` instance to schedule learning rate.
+        ``NoamDecay`` instance to schedule learning rate.

    Examples:
        .. code-block:: python

            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -262,23 +317,21 @@ class PiecewiseLR(_LRScheduler):
            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -346,23 +399,21 @@ class NaturalExpLR(_LRScheduler):
            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -939,23 +984,21 @@ class StepLR(_LRScheduler):
            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -1035,23 +1078,21 @@ class LambdaLR(_LRScheduler):
            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -1135,23 +1176,21 @@ class ReduceLROnPlateau(_LRScheduler):
            import paddle
            import numpy as np


python/paddle/optimizer/lr.py

@@ -1352,23 +1382,21 @@ class CosineAnnealingLR(_LRScheduler):
            import paddle
            import numpy as np


TCChenlong · 2020-10-12T04:57:53Z

python/paddle/optimizer/optimizer.py

@@ -370,14 +372,14 @@ def get_lr(self):

                import numpy as np


这行可以删除

… develop

TCChenlong

LGTM

XiaoguangHu01

LGTM

raindrops2sea

lgtm

…er (PaddlePaddle#27686) * fix doc and unittest of 2.0 lr_scheduler * fix doc of 2.0 lr_scheduler * fix unittest * fix english doc of lr_scheduler * fix api name of lr scheduler * fix api name of lr scheduler

fix doc and unittest of 2.0 lr_scheduler

0d90a8a

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 2fb481c to 0d90a8a Compare September 28, 2020 12:06

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

af52196

… develop

zhwesky2010 changed the title ~~fix doc and unittest of 2.0 lr_scheduler~~ fix english doc、unittest、remove useless alias of 2.0 lr_scheduler Sep 29, 2020

zhwesky2010 changed the title ~~fix english doc、unittest、remove useless alias of 2.0 lr_scheduler~~ fix english doc, unittest, remove useless alias of 2.0 lr_scheduler Sep 29, 2020

zhwesky2010 added 2 commits September 29, 2020 04:08

fix doc of 2.0 lr_scheduler

dda3f4e

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

7ea6387

… develop

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 3ab4e05 to 7ea6387 Compare September 29, 2020 04:12

fix unittest

0ff5211

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 31108b8 to c301601 Compare September 29, 2020 09:34

zhwesky2010 changed the title ~~fix english doc, unittest, remove useless alias of 2.0 lr_scheduler~~ fix english doc, unittest, and remove useless alias of 2.0 lr_scheduler Sep 29, 2020

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

476f8e3

… develop

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from c301601 to 476f8e3 Compare September 29, 2020 11:35

PaddlePaddle locked and limited conversation to collaborators Sep 29, 2020

PaddlePaddle unlocked this conversation Sep 29, 2020

PaddlePaddle locked and limited conversation to collaborators Sep 30, 2020

PaddlePaddle unlocked this conversation Sep 30, 2020

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 813be9d to b686e04 Compare September 30, 2020 06:11

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch 2 times, most recently from 3f7b738 to 8e9e055 Compare September 30, 2020 07:24

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 8e9e055 to cc83284 Compare September 30, 2020 10:06

fix english doc of lr_scheduler

961560d

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from cc83284 to 961560d Compare September 30, 2020 10:27

zhwesky2010 added 2 commits September 30, 2020 10:47

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

93c8a7a

… develop

fix api name of lr scheduler

ddb1b7b

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 87c1785 to db78404 Compare October 10, 2020 03:35

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from db78404 to af8a6d1 Compare October 10, 2020 04:23

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from af8a6d1 to 81582b4 Compare October 10, 2020 04:39

fix api name of lr scheduler

94722d7

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 81582b4 to 0d34d19 Compare October 11, 2020 16:13

XiaoguangHu01 previously approved these changes Oct 12, 2020

View reviewed changes

TCChenlong reviewed Oct 12, 2020

View reviewed changes

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d45af89

… develop

zhwesky2010 dismissed XiaoguangHu01’s stale review via d45af89 October 12, 2020 05:22

zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch from 0d34d19 to d45af89 Compare October 12, 2020 05:22

TCChenlong approved these changes Oct 12, 2020

View reviewed changes

XiaoguangHu01 approved these changes Oct 12, 2020

View reviewed changes

zhwesky2010 requested a review from raindrops2sea October 13, 2020 03:03

raindrops2sea approved these changes Oct 13, 2020

View reviewed changes

zhwesky2010 merged commit e122e16 into PaddlePaddle:develop Oct 13, 2020

zhwesky2010 changed the title ~~fix english doc, unittest, and remove useless alias of 2.0 lr_scheduler~~ fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

zhwesky2010 commented Sep 28, 2020 •

edited

Loading

paddle-bot-old bot commented Sep 28, 2020

XiaoguangHu01 left a comment

TCChenlong Oct 12, 2020

TCChenlong Oct 12, 2020

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

TCChenlong Oct 12, 2020

zhwesky2010 Oct 12, 2020

TCChenlong left a comment

XiaoguangHu01 left a comment

raindrops2sea left a comment

		@@ -262,23 +317,21 @@ class PiecewiseLR(_LRScheduler):
		import paddle
		import numpy as np

		@@ -346,23 +399,21 @@ class NaturalExpLR(_LRScheduler):
		import paddle
		import numpy as np

		@@ -939,23 +984,21 @@ class StepLR(_LRScheduler):
		import paddle
		import numpy as np

		@@ -1035,23 +1078,21 @@ class LambdaLR(_LRScheduler):
		import paddle
		import numpy as np

		@@ -1135,23 +1176,21 @@ class ReduceLROnPlateau(_LRScheduler):
		import paddle
		import numpy as np

		@@ -1352,23 +1382,21 @@ class CosineAnnealingLR(_LRScheduler):
		import paddle
		import numpy as np

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

Conversation

zhwesky2010 commented Sep 28, 2020 • edited Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Sep 28, 2020

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

zhwesky2010 Oct 12, 2020

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

raindrops2sea left a comment

Choose a reason for hiding this comment

zhwesky2010 commented Sep 28, 2020 •

edited

Loading