fix pool3d bug, test=develop #27718
Merged
fix pool3d bug, test=develop #27718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
willthefrog
requested changes
Sep 29, 2020
| (exclusive || adaptive) | ||
| ? (dend - dstart) * (hend - hstart) * (wend - wstart) | ||
| : ksize_depth * ksize_height * ksize_width; | ||
| if (exclusive || adaptive) { |
There was a problem hiding this comment.
this check seems redundant now, isn't pool_size always the same value?
There was a problem hiding this comment.
It is not redundant to updatepool_size when padding is not zero.
The variable pool_size will be updated after running the following code.
pool_size = (dend - dstart) * (hend - hstart) * (wend - wstart);
dstart = std::max(dstart, 0);
hstart = std::max(hstart, 0);
wstart = std::max(wstart, 0);
dend = std::min(dend, input_depth);
hend = std::min(hend, input_height);
wend = std::min(wend, input_width);
Got it! |
ceci3
approved these changes
Oct 10, 2020
willthefrog
approved these changes
Oct 10, 2020
LDOUBLEV
added a commit
to LDOUBLEV/Paddle
that referenced
this pull request
Oct 12, 2020
* fix pool3d bug, test=develop * fix unitest, test=develop * fix test and fix pool2d bug, test=develop
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
* fix pool3d bug, test=develop * fix unitest, test=develop * fix test and fix pool2d bug, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
fix pool3d bug, http://newicafe.baidu.com/v5/issue/DLTP-12154/show?cid=5