Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsigmoid -> hsigmoid_loss/HSigmoidLoss; refine docs #27745

Merged
merged 7 commits into from
Oct 12, 2020
Merged

hsigmoid -> hsigmoid_loss/HSigmoidLoss; refine docs #27745

merged 7 commits into from
Oct 12, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Sep 30, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  • move hsigmoid (activation) to hsigmoid_loss/HSigmoidLoss (loss)
  • refine docs.

en_0
en_1

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

hong19860320
hong19860320 previously approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit previously approved these changes Oct 11, 2020
View reviewed changes
zhiqiu
zhiqiu approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hong19860320
hong19860320 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 659d04d into PaddlePaddle:develop Oct 12, 2020
@zhupengyang zhupengyang deleted the hsigmoid branch October 12, 2020 07:09
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@zhupengyang @chen-zhiyu
hsigmoid -> hsigmoid_loss/HSigmoidLoss; refine docs (PaddlePaddle#27745)
fdbaf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolinwei kolinwei kolinwei approved these changes

@hong19860320 hong19860320 hong19860320 approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@lanxianghit lanxianghit lanxianghit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhupengyang @zhiqiu @hong19860320 @kolinwei @lanxianghit