Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bfloat16 resnet50 test #27755

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add bfloat16 resnet50 test #27755

merged 1 commit into from
Oct 13, 2020

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Oct 2, 2020

PR types

New features

PR changes

Others

Describe

This PR:

  • adds SetBfloat16Op to C-api that allows you to choose which operators should be run on bfloat16
  • adds Resnet50 bfloat16 test
  • unifies int8 and bfloat16 image classification tests

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wozna
Copy link
Contributor Author

wozna commented Oct 12, 2020

@luotao1 We have a problem with PR-CI-Coverage because it looks that PR-CI-Coverage is built as a Release version. By checking the coverage locally on the debug all lines are covered. There are optimizations on Release that make it impossible to cover all lines, e.g.
MicrosoftTeams-image

@luotao1
Copy link
Contributor

luotao1 commented Oct 12, 2020

The usage of SetBfloat16Op is not distinguished between Release version and Debug version. I don't see where the usage of SetBfloat16Op in Debug version?

@wozna
Copy link
Contributor Author

wozna commented Oct 12, 2020

It is used in paddle/fluid/inference/tests/api/analyzer_bfloat16_image_classification_tester.cc . It looks that function SetBfloat16Op was inlined somehow that is why only code inside function was covered.

@luotao1
Copy link
Contributor

luotao1 commented Oct 12, 2020

Got it. @XieYunshen Could you help see this coverage problem?

wojtuss
wojtuss approved these changes Oct 13, 2020
View reviewed changes
Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ddcd1b5 into PaddlePaddle:develop Oct 13, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@wozna @chen-zhiyu
Add bfloat16 resnet50 test (PaddlePaddle#27755)
5b60f27
@luotao1 luotao1 mentioned this pull request Oct 16, 2020
Closed
@wozna wozna deleted the bfloat16_test_resnet branch February 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtuss wojtuss wojtuss approved these changes

Assignees
No one assigned
Labels
BF16 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wozna @luotao1 @wojtuss