Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for windows compile. #27813

Merged
merged 1 commit into from
Oct 11, 2020
Merged

update for windows compile. #27813

merged 1 commit into from
Oct 11, 2020

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Oct 10, 2020

PR types

Others

PR changes

Others

Describe

Update for windows compile: add Os flag.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

DannyIsFunny
DannyIsFunny approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit a2d08aa into PaddlePaddle:develop Oct 11, 2020
@jiweibo jiweibo deleted the windows_compile branch October 11, 2020 01:10
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@jiweibo @chen-zhiyu
update for windows compile. (PaddlePaddle#27813)
0b93b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyIsFunny DannyIsFunny DannyIsFunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiweibo @DannyIsFunny