Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of Model.save #27815

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

LiuChiachi
Copy link
Contributor

@LiuChiachi LiuChiachi commented Oct 10, 2020

PR types

Bug fixes

PR changes

APIs

Describe

  1. Fix bug of Model.save. Inputs in Model initialization can be an InputSpec instance and I ignored this before.
  2. Add member functions _update_inputs for class Model to reuse code.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LiuChiachi LiuChiachi changed the title Fix bug of model.save. Inputs in Model initialization can be an InputSpec instance Fix bug of Model.save. Inputs in Model initialization can be an InputSpec instance Oct 10, 2020
@LiuChiachi LiuChiachi changed the title Fix bug of Model.save. Inputs in Model initialization can be an InputSpec instance Fix bug of Model.save. Oct 10, 2020
@LiuChiachi LiuChiachi changed the title Fix bug of Model.save. Fix bug of Model.save Oct 10, 2020
@guoshengCS guoshengCS merged commit b84d4ae into PaddlePaddle:develop Oct 12, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
* fix model bugs, inputs can be InputSpec instance

* correct error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants