Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/embedding doc #27816

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Conversation

seiriosPlus
Copy link
Collaborator

PR types

Others

PR changes

Docs

Describe

update embedding doc with paddle2.0

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦用注释的形式打印下embedding这个api在这两个示例代码中的输入和输出tensor

zhiqiu
zhiqiu previously approved these changes Oct 12, 2020
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for embedding without core.ops since it is used in static graph.

Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu self-requested a review October 12, 2020 07:05
@seiriosPlus seiriosPlus merged commit e96fc6a into PaddlePaddle:develop Oct 12, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
* fix fluid doc

* fix fluid doc

* fix fluid doc, test=document_fix

* fix fluid doc, test=document_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants