Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go testing into cmake #2811

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Add go testing into cmake #2811

merged 2 commits into from
Jul 12, 2017

Conversation

helinwang
Copy link
Contributor

@helinwang helinwang commented Jul 11, 2017 •
edited
Loading

Fixes: #2656

@helinwang helinwang force-pushed the go_test_1 branch 8 times, most recently from 216213c to 5702c9a Compare July 12, 2017 06:38
@helinwang helinwang changed the title WIP: add go testing into cmake Add go testing into cmake Jul 12, 2017
gangliao
gangliao approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see this pull request whether can pass CI system or not!

@helinwang helinwang force-pushed the go_test_1 branch 2 times, most recently from e2f2dd1 to 76bc76f Compare July 12, 2017 20:13
@helinwang helinwang merged commit f5f7d6b into PaddlePaddle:develop Jul 12, 2017
@helinwang helinwang deleted the go_test_1 branch July 12, 2017 23:09
@helinwang helinwang mentioned this pull request Jul 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangliao gangliao gangliao approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helinwang @gangliao