添加rocm平台支持代码 #29342
Merged
添加rocm平台支持代码 #29342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qili93
reviewed
Dec 3, 2020
cmake/external/pybind11.cmake
Outdated
| @@ -39,7 +39,7 @@ ExternalProject_Add( | |||
| # to be modified without triggering incremental compilation, and the | |||
| # third-party library version changes cannot be incorporated. | |||
| # reference: https://cmake.org/cmake/help/latest/module/ExternalProject.html | |||
| UPDATE_COMMAND "" | |||
| # UPDATE_COMMAND "" | |||
qili93
reviewed
Dec 3, 2020
cmake/hip.cmake
Outdated
|
|
||
| set(HIP_HCC_FLAGS "${HIP_HCC_FLAGS} -fPIC -DPADDLE_WITH_HIP -std=c++11" ) | ||
| #include_directories("${ROCM_PATH}/thrust") |
qili93
reviewed
Dec 3, 2020
| DEFINE_string(miopen_dir, "", | ||
| "Specify path for loading libcudnn.so. For instance, " | ||
| "/usr/local/cudnn/lib. If empty [default], dlopen " | ||
| "will search cudnn from LD_LIBRARY_PATH"); |
There was a problem hiding this comment.
string的内容需要修改下？应该不是libcudnn.so，也不是search cudnn。
qili93
reviewed
Dec 3, 2020
| "Specify path for loading cuda library, such as libcublas, " | ||
| "libcurand, libcusolver. For instance, /usr/local/cuda/lib64. " | ||
| "If default, dlopen will search cuda from LD_LIBRARY_PATH"); | ||
|
|
There was a problem hiding this comment.
同样不是cuda library, 也不是search cuda
qili93
reviewed
Dec 3, 2020
| DEFINE_string(rccl_dir, "", | ||
| "Specify path for loading nccl library, such as libnccl.so. " | ||
| "For instance, /usr/local/cuda/lib64. If default, " | ||
| "dlopen will search cuda from LD_LIBRARY_PATH"); |
There was a problem hiding this comment.
不是nccl, 也不是/usr/local/cuda/lib64, 也不是search cuda
qili93
reviewed
Dec 3, 2020
|
|
||
| #define ROCBLAS_BLAS_ROUTINE_EACH_R4(__macro) \ | ||
| __macro(rocblas_gemm_batched_ex); \ | ||
| // __macro(rocblas_gemm_strided_batched_ex); |
qili93
reviewed
Dec 3, 2020
| __macro(rocblas_dgemm); \ | ||
| __macro(rocblas_hgemm); \ | ||
| __macro(rocblas_dgeam); \ | ||
| /*__macro(rocblas_gemm_ex); */\ |
qili93
reviewed
Dec 3, 2020
| __macro(hipModuleLoadData); \ | ||
| __macro(hipModuleGetFunction); \ | ||
| __macro(hipModuleUnload); \ | ||
| /* __macro(hipOccupancyMaxActiveBlocksPerMultiprocessor);*/ \ |
There was a problem hiding this comment.
好滴 这些目前在rocm3.5 上还木有对应的支持
phlrain
reviewed
Dec 14, 2020
| @@ -0,0 +1,36 @@ | |||
| /* Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
@phlrain 改好啦 麻烦你再看看呢
qili93
approved these changes
Dec 15, 2020
phlrain
approved these changes
Dec 15, 2020
raindrops2sea
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
1、修改编译选项WITH_AMD_GPU为 WITH_ROCM_PLATFORM
2、为rocm平台添加相关编译选项
3、添加ROCM 平台底层代码调用：dynload，完善miopen/hiprand/rocblas/rocrand等相关库的调用接口
扩展paddle框架的硬件适用范围，
编译参数：
cmake .. -DPYTHON_EXECUTABLE=$PATH_PYTHON/bin/python3 -DPYTHON_INCLUDE_DIR=$PATH_PYTHON/include
-DPYTHON_LIBRARY=$PATH_PYTHON/lib/libpython3.so -DCMAKE_BUILD_TYPE=Release -DWITH_GPU=OFF -DWITH_GLOO=OFF -DWITH_TP_CACHE=ON -DWITH_TESTING=ON -DWITH_MKL=OFF -DWITH_NCCL=OFF -DWITH_ROCM_PLATFORM=ON
os：CentOS Linux release 7.7.1908
GCC：7.3.1
cmake:3.18
rocm:3.5