Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in_out_idxs_ to shared_ptr #2935

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Change in_out_idxs_ to shared_ptr #2935

merged 1 commit into from
Jul 18, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 18, 2017

  • in_out_idxs_ shares between all operator instance in same type
    of operator.

@reyoung reyoung requested a review from Superjomn July 18, 2017 05:52
Superjomn
Superjomn approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung
Change in_out_idxs_ to shared_ptr
c1219a5 
* `in_out_idxs_` shares between all operator instance in same type
  of operator.
@reyoung reyoung force-pushed the feature/create_op_use_cpp_params branch from f50ff3d to c1219a5 Compare July 18, 2017 05:54
@reyoung reyoung merged commit 875946f into PaddlePaddle:develop Jul 18, 2017
@reyoung reyoung deleted the feature/create_op_use_cpp_params branch July 18, 2017 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @Superjomn