Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor should use PADDLE_ONLY_CPU macro #2939

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Tensor should use PADDLE_ONLY_CPU macro #2939

merged 1 commit into from
Jul 19, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 18, 2017

  • Not use CUDACC macro, because malloc in GPU memory do not have to
    used in .cu file.
  • Also, PADDLE_ENFORCE logic is wrong.

@reyoung
Tensor should use PADDLE_ONLY_CPU macro
9b964b5 
* Not use __CUDACC__ macro, because malloc in GPU memory do not have to
  used in .cu file.
* Also, `PADDLE_ENFORCE` logic is wrong.
@reyoung reyoung requested a review from JiayiFeng July 18, 2017 08:19
JiayiFeng
JiayiFeng approved these changes Jul 18, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit b90780c into PaddlePaddle:develop Jul 19, 2017
@reyoung reyoung deleted the feature/refine_tensor_hpp branch July 19, 2017 08:46
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@jerrywgz
add Cython in requirement (PaddlePaddle#2939)
99143a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @JiayiFeng