[Feature] one ps (2/4) #29560
Merged
[Feature] one ps (2/4) #29560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7c7b144e121bbce9e1b1b4c60bf8c64e718d1593
|
Thanks for your contribution! |
Change-Id: Iaa710ff34a1810123a29409d632890e64d743c58
Change-Id: I424c548b1f6dcdbd52867a888a5ce0c45cad9f36
Change-Id: Ie07daace3f6877e8a0e53db03df07c034999e0bb
Change-Id: I53fc37b1cc0022c75f3ec2deaebde1eb3928e5a0
Change-Id: I7e40479137290802eea212c1e90e41d7fee68a5c
fuyinno4
approved these changes
Dec 14, 2020
raindrops2sea
approved these changes
Dec 14, 2020
chenwhql
approved these changes
Dec 14, 2020
| virtual std::future<int32_t> send_client2client_msg(int msg_type, | ||
| int to_client_id, | ||
| const std::string &msg) { | ||
| LOG(FATAL) << "Did not implement"; |
There was a problem hiding this comment.
建议还是用统一的报错格式写比较好，可以在后续PR完善
kolinwei
approved these changes
Dec 14, 2020
seiriosPlus
added a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 24, 2020
* add service, remove ut on mac * fix heter_profiler & add heter stop method * fix code style
seiriosPlus
added a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 24, 2020
* add service, remove ut on mac * fix heter_profiler & add heter stop method * fix code style
fuyinno4
pushed a commit
that referenced
this pull request
Dec 24, 2020
fuyinno4
pushed a commit
that referenced
this pull request
Dec 25, 2020
* add ps table (#29463) * add ps table Change-Id: I468a04bd071d21ff52654926fcf4d5f3da19e178 * add service (#29560) * add service, remove ut on mac * fix heter_profiler & add heter stop method * fix code style * merge pscore Change-Id: Ie7f60d1cdde6755a0c29db26863c6283e9843d57 * fix cmake Change-Id: I6773509a7b4ca79139ecc40b7bf3eb318ceff8bb * fix conflit Change-Id: I35575be0c96a8520f9d756ea7f1ff0b904a165ba * fix conflit Change-Id: Ic926ea0b0d67803226d51241397ba3b510226bfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
2/4 for OnePS. Team work with @123malin @MrChengmo
PS整合方案(2/3)
本次合入：