Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cublas_handle() to expose cublas_handle to ops #31157

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

FrostML
Copy link
Contributor

@FrostML FrostML commented Feb 23, 2021

PR types

Others

PR changes

Others

Describe

Add cublas_handle() to expose cublas_handle for ops.
This is used for custom op faster transformer.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FrostML FrostML requested a review from zhiqiu February 24, 2021 03:32
@@ -459,6 +459,10 @@ cudnnHandle_t CUDADeviceContext::cudnn_handle() const {
return context()->CudnnHandle();
}

cublasHandle_t CUDADeviceContext::get_cublas_handle() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest get_cublas_handle() -> cublas_handle(), keep consistent with other function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrostML FrostML changed the title Add get_cublas_handle() Add cublas_handle() to expose cublas_handle to ops Feb 24, 2021
@FrostML FrostML merged commit ae2be49 into PaddlePaddle:develop Feb 24, 2021
FrostML added a commit to FrostML/Paddle that referenced this pull request Feb 24, 2021
* add get_cublas_handle() api

* update format

* add unittests

* alter function name
XiaoguangHu01 pushed a commit that referenced this pull request Feb 25, 2021
* add get_cublas_handle() api

* update format

* add unittests

* alter function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants