[ROCM] update fluid operators for rocm (part3), test=develop #31213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Superjomn
reviewed
Mar 1, 2021
| @@ -41,7 +41,7 @@ HOSTDEVICE inline int64_t BinarySearch(const T *x, int64_t num, const T &val) { | |||
|
|
|||
| template <typename T> | |||
| HOSTDEVICE inline size_t LowerBound(const T *x, size_t num, const T &val) { | |||
| #ifdef __CUDA_ARCH__ | |||
| #if defined(__CUDA_ARCH__) || defined(__HIPCC__) | |||
There was a problem hiding this comment.
全局宏 if, elif, else 比较多，中间间隔的代码也比较长，阅读起来比较碎片化
建议加一些注释来让代码片段区间更清晰些，比如
#if defined(__CUDA_ARCH__) || defined(__HIPCC__) // @ {
...
// @ }
#else // @ {
// @ }这样跨了多行的宏读起来能对应起来
参考 https://www.doxygen.nl/manual/grouping.html#memgroup ，不确定有没有更好的方式
There was a problem hiding this comment.
Done, 给跨度比较大的被宏包围的代码添加了注释
qili93
force-pushed
the
rocm_operators_part3
branch
from
af63fa5
to
720bcdc
Compare
qili93
force-pushed
the
rocm_operators_part3
branch
from
720bcdc
to
670de55
Compare
… rocm_operators_part3
GaoWei8
approved these changes
Mar 3, 2021
luotao1
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
[ROCM] update fluid operators for rocm (part3)