Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prec on windows exclude check_added_ut #31372

Merged

Conversation

XieYunshen
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Windows精准测试,相对于Linux缺少针对仅有新增单测PR的检查,但影响较小

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试了精准测试会生效吧。

另外,后面做一下 PR单测的检测

@zhwesky2010 zhwesky2010 self-requested a review March 3, 2021 04:16
@@ -210,6 +211,34 @@ export CUDA_VISIBLE_DEVICES=0
UT_list=$(ctest -N | awk -F ': ' '{print $2}' | sed '/^$/d' | sed '$d')
num=$(ctest -N | awk -F ': ' '{print $2}' | sed '/^$/d' | sed '$d' | wc -l)
echo "Windows 1 card TestCases count is $num"
if [ ${PRECISION_TEST:-OFF} == "ON" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRECISION_TEST 这个环境变量是不是还没有在CI里面设置为ON,所以这段逻辑还没有触发到

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,合入后,在任务中再打开

@zhwesky2010 zhwesky2010 self-requested a review March 3, 2021 06:19
@XieYunshen XieYunshen merged commit 390cebe into PaddlePaddle:develop Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants