Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] fix softmax with loss and update ci, test=develop #31373

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[ROCM] fix softmax with loss and update ci, test=develop #31373

merged 1 commit into from
Mar 3, 2021

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Mar 2, 2021

PR types

New features

PR changes

OPs

Describe

[ROCM] fix softmax with loss and update ci python scripts

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@qili93 qili93 requested a review from yghstill March 2, 2021 12:15
yghstill
yghstill approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@yghstill yghstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change of precision threshold for rocm. But I suggest a more common method to avoid change all unittest files.

@qili93 qili93 merged commit db50fb6 into PaddlePaddle:develop Mar 3, 2021
@qili93 qili93 deleted the rocm_op_and_ci branch March 3, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yghstill yghstill yghstill approved these changes

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qili93 @Xreki @yghstill