[oneDNN] elementwise add bf16 grad kernel with broadcasting #31385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
- compilation fix - compiltion fix - working reduction - Added other bradcinding scenarios for elementwise_add grad - added UT for bf16 elementwise_add_grad broadcasting - lint - Enabled some missing tests for grad - warnings fixed - pylint fixes - Lint fixes - another lint fixes
jczaja
force-pushed
the
prv-reduction-primitive
branch
from
3ca11bd
to
1a1525d
Compare
|
@arlesniak , @jakpiase Could you please review this PR? |
|
@luotao1 Could you please start your review? PR-CI-APPROVAL will not pass without your approval. |
luotao1
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
elementwise_add bf16 grad kernel was extended to support broadcasting. This is needed for word2vec bf16 training enablement