Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] remove md5 check since different machine generate different binary file #31482

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

lidanqing-intel
Copy link
Contributor

@lidanqing-intel lidanqing-intel commented Mar 8, 2021

PR types

Bug fixes

PR changes

Others

Describe

Found that in icelake, generate binary file is slightly different in digits (represented float value should be very close), so the md5 is different. We can not use same md5 for different machines.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel lidanqing-intel changed the title Different machine generate different binary file, remove md5 check [Bug fix] Different machine generate different binary file, remove md5 check Mar 8, 2021
@lidanqing-intel
Copy link
Contributor Author

@wojtuss Hi, Please review

Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 0f1e7e3 into PaddlePaddle:develop Mar 11, 2021
@lidanqing-intel lidanqing-intel changed the title [Bug fix] Different machine generate different binary file, remove md5 check [Bug fix] remove md5 check since different machine generate different binary file Mar 11, 2021
@lidanqing-intel lidanqing-intel deleted the integrity-md5-error branch June 20, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants