Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CustomOp] Normalized function parameter writing #31588

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[CustomOp] Normalized function parameter writing #31588

merged 1 commit into from
Mar 15, 2021

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Mar 12, 2021 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

[CustomOp] Normalized function parameter writing

For all function inputs, change to use const & format:

  • Make the function writing conform to the programming style guide
  • Reduce copying and improve efficiency
  • At the same time, it is compatible with the written method that has been released in 2.0.1

JiabinYang
JiabinYang approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 30a627a into PaddlePaddle:develop Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenwhql @JiabinYang