ignore im2col if not necessary in conv 1 * 1 #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
requested changes
Aug 2, 2017
paddle/function/GemmConvOp.cpp
Outdated
| @@ -66,16 +66,23 @@ class GemmConvFunction : public ConvFunctionBase { | |||
| real* inputData = inputs[0].data<real>(); | |||
| real* filterData = inputs[1].data<real>(); | |||
| real* outputData = outputs[0].data<real>(); | |||
| bool skipIm2col = isSkipIm2col(filter); | |||
There was a problem hiding this comment.
skipIm2col换成needIm2col是否更好理解?
paddle/function/GemmConvOp.cpp
Outdated
| resizeBuffer<Device>(colShape.getElements()); | ||
| real* colData = reinterpret_cast<real*>(memory_->getBuf()); | ||
| TensorShape colShape; | ||
| real *colBuffer, *colData = NULL; |
There was a problem hiding this comment.
一行定义一个变量。实际上只需要一个colData变量就够了。
97行写成
if (needIm2col) {
im2col(colData);
} else {
colData = inputData + g * inputOffset;
}
paddle/function/GemmConvOp.cpp
Outdated
| @@ -182,6 +200,12 @@ class GemmConvGradInputFunction : public ConvFunctionBase { | |||
| int K = outputChannels / groups_; | |||
| int N = outputHeight * outputWidth; | |||
| int M = inputChannels / groups_ * filterHeight * filterWidth; | |||
| colBuffer = colData; | |||
| real scale = 0.0f; | |||
There was a problem hiding this comment.
203-204写到if(skipIm2col)...else里面吧
There was a problem hiding this comment.
real scale = 0.0 没必要放在if else 中吧
hedaoyuan
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore im2col when this happens in conv:
I did a test of mobilenet forward process on Developing machine(Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz), the average cost time on 100 times forward pass of one batch is about 15 ms faster than the normal one.