Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPU] Fix bug: Fix calculation errors of pow grad npu kernel #31699

Merged
merged 1 commit into from
Mar 17, 2021
Merged

[NPU] Fix bug: Fix calculation errors of pow grad npu kernel #31699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions paddle/fluid/operators/activation_op_npu.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class PowGradNPUKernel : public framework::OpKernel<T> {
Tensor x_power_mul_factor(x->type());
x_power_mul_factor.mutable_data<T>(x->dims(), place);
auto runner_mul_1 =
NpuOpRunner("Mul", {factor_bc_tensor, *x}, {x_power_mul_factor}, {});
NpuOpRunner("Mul", {factor_bc_tensor, x_pow}, {x_power_mul_factor}, {});
runner_mul_1.Run(stream);

// Step 4: Compute dx = dout * factor * x.pow(factor-1)
Expand Down Expand Up @@ -309,20 +309,17 @@ class SquareNPUKernel : public framework::OpKernel<T> {
namespace ops = paddle::operators;

REGISTER_OP_NPU_KERNEL(
pow,
ops::PowNPUKernel<paddle::platform::NPUDeviceContext, float>,
pow, ops::PowNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::PowNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
pow_grad,
ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
pow_grad, ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::PowGradNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
relu,
ops::ReluNPUKernel<paddle::platform::NPUDeviceContext, float>,
relu, ops::ReluNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::ReluNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);

Expand All @@ -333,33 +330,28 @@ REGISTER_OP_NPU_KERNEL(
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
sqrt,
ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext, float>,
sqrt, ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::SqrtNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
sqrt_grad,
ops::SqrtGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::SqrtGradNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
log,
ops::LogNPUKernel<paddle::platform::NPUDeviceContext, float>,
log, ops::LogNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::LogNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
log_grad,
ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
log_grad, ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::LogGradNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);


REGISTER_OP_NPU_KERNEL(
tanh,
ops::TanhNPUKernel<paddle::platform::NPUDeviceContext, float>,
tanh, ops::TanhNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::TanhNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);

Expand All @@ -370,7 +362,6 @@ REGISTER_OP_NPU_KERNEL(
paddle::platform::float16>);

REGISTER_OP_NPU_KERNEL(
square,
ops::SquareNPUKernel<paddle::platform::NPUDeviceContext, float>,
square, ops::SquareNPUKernel<paddle::platform::NPUDeviceContext, float>,
ops::SquareNPUKernel<paddle::platform::NPUDeviceContext,
paddle::platform::float16>);