-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use busybox run test on windows openblas #31728
use busybox run test on windows openblas #31728
Conversation
Thanks for your contribution! |
paddle/scripts/paddle_build.bat
Outdated
@@ -502,7 +502,7 @@ echo ======================================== | |||
echo Running CPU unit tests in parallel way ... | |||
echo ======================================== | |||
|
|||
ctest.exe -E "(%disable_ut_quickly%)" -LE %nightly_label% --output-on-failure -C Release -j 8 --repeat until-pass:4 after-timeout:4 | |||
%cache_dir%\tools\busybox64.exe bash %work_dir%\tools\windows\run_unittests_cpu.sh %NIGHTLY_MODE% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以合并到一行命令,加个参数WITH_GPU就可以了
tools/windows/run_unittests_cpu.sh
Outdated
@@ -0,0 +1,146 @@ | |||
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件可以合并到run_unittests.sh文件里吗?因为感觉是其中的一个分支,加个参数WITH_GPU走不同分支
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
小问题,可以后面改,LGTM
tools/windows/run_unittests.sh
Outdated
run_unittest $non_parallel_job_1 | ||
run_unittest $non_parallel_job_2 | ||
if [ "${WITH_GPU:-OFF}" == "ON" ];then | ||
run_unittest $eight_parallel_job 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以把这个名字改成 run_unittest_gpu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
fix error
PR types
Others
PR changes
Others
Describe
使用Bash执行Windows openblas任务中的单测
修改openblas任务中执行retry的方法,与其它任务对齐