Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use busybox run test on windows openblas #31728

Merged
merged 11 commits into from
Apr 2, 2021

Conversation

XieYunshen
Copy link
Contributor

@XieYunshen XieYunshen commented Mar 18, 2021

PR types

Others

PR changes

Others

Describe

使用Bash执行Windows openblas任务中的单测
修改openblas任务中执行retry的方法,与其它任务对齐

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -502,7 +502,7 @@ echo ========================================
echo Running CPU unit tests in parallel way ...
echo ========================================

ctest.exe -E "(%disable_ut_quickly%)" -LE %nightly_label% --output-on-failure -C Release -j 8 --repeat until-pass:4 after-timeout:4
%cache_dir%\tools\busybox64.exe bash %work_dir%\tools\windows\run_unittests_cpu.sh %NIGHTLY_MODE%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以合并到一行命令,加个参数WITH_GPU就可以了

@@ -0,0 +1,146 @@
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件可以合并到run_unittests.sh文件里吗?因为感觉是其中的一个分支,加个参数WITH_GPU走不同分支

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

zhwesky2010
zhwesky2010 previously approved these changes Mar 29, 2021
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小问题,可以后面改,LGTM

run_unittest $non_parallel_job_1
run_unittest $non_parallel_job_2
if [ "${WITH_GPU:-OFF}" == "ON" ];then
run_unittest $eight_parallel_job 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把这个名字改成 run_unittest_gpu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

zhwesky2010
zhwesky2010 previously approved these changes Mar 30, 2021
@XieYunshen XieYunshen merged commit 290be88 into PaddlePaddle:develop Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants