Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigmoid backward implementation. #3181

Merged
merged 5 commits into from
Aug 7, 2017

Conversation

qingqing01
Copy link
Contributor

Fix #3149

@@ -12,5 +12,8 @@ def setUp(self):
self.Y = 1 / (1 + np.exp(-self.X))


#class TestSigmoidGradOp(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add USE_OP(sigmoid_grad) in bybind, and test in python side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzhwinter Thanks, I'll add unit test after the unit test is ready for the backward op.

Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@wangkuiyi wangkuiyi merged commit efa50a4 into PaddlePaddle:develop Aug 7, 2017
@qingqing01 qingqing01 deleted the sigmoid_bp branch March 7, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants