Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom OP]Remove old custom OP and reduce whl package volume #31813

Merged
merged 3 commits into from
Mar 30, 2021
Merged

[Custom OP]Remove old custom OP and reduce whl package volume #31813

merged 3 commits into from
Mar 30, 2021

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Mar 23, 2021 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

2.1将要移除旧自定义OP方案，避免同时呈现给用户两套方案造成误解。

新自定义OP，对库与头文件进行了封装精简，将无需要用到的库与头文件进行清理精简，不打包到whl中，能够降低一些whl包体积。

whl包体积数据：

  • 合入前：Linux：120M，Windows: 122M

  • 合入后：Linux：113M，Windows: 115M

  • whl package减少7M，约6%

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title Remove old custom op Remove old custom OP to reduce whl package volume Mar 23, 2021
@zhwesky2010 zhwesky2010 changed the title Remove old custom OP to reduce whl package volume [Custom OP]Remove old custom OP to reduce whl package volume Mar 24, 2021
@zhwesky2010 zhwesky2010 changed the title [Custom OP]Remove old custom OP to reduce whl package volume [Custom OP]Remove old custom OP and reduce whl package volume Mar 25, 2021
Aurelius84
Aurelius84 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhwesky2010 zhwesky2010 merged commit 04a49b0 into PaddlePaddle:develop Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanxianghit lanxianghit lanxianghit approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@chenwhql chenwhql chenwhql approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@jzhang533 jzhang533 jzhang533 approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

@JiabinYang JiabinYang Awaiting requested review from JiabinYang

@phlrain phlrain Awaiting requested review from phlrain

@TCChenlong TCChenlong Awaiting requested review from TCChenlong

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zhwesky2010 @jzhang533 @Aurelius84 @chenwhql @raindrops2sea @Shixiaowei02 @lanxianghit @luotao1