Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added oneDNN reduce_op FWD kernel #31816

Merged
merged 30 commits into from
Apr 14, 2021
Merged

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Mar 23, 2021

PR types

New features

PR changes

OPs

Describe

Added oneDNN reduce_op FWD fp32 and bf16 kernels (reduce_max, reduce_min, reduce_mean, reduce_mul). Backward operator will be implemented in the nearest future.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase changed the title Added oneDNN reduce_op kernel Added oneDNN reduce_op FWD kernel Apr 7, 2021
@jakpiase
Copy link
Contributor Author

@luotao1 I have reran PR-CI-OP_benchmark 12 times for now and with each run I am getting different errors. I don't think that my PR is related to them. Could you please help me in finding solution to this problem?

@luotao1
Copy link
Contributor

luotao1 commented Apr 13, 2021

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:260] [ERROR] Missing test script of "reduce_any"(paddle/fluid/operators/reduce_ops/reduce_any_op.cu) in benchmark.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:260] [ERROR] Missing test script of "reduce_min"(paddle/fluid/operators/reduce_ops/reduce_min_op.cu) in benchmark.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:260] [ERROR] Missing test script of "frobenius_norm"(paddle/fluid/operators/reduce_ops/frobenius_norm_op.cu) in benchmark.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:260] [ERROR] Missing test script of "reduce_max"(paddle/fluid/operators/reduce_ops/reduce_max_op.cu) in benchmark.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:260] [ERROR] Missing test script of "reduce_all"(paddle/fluid/operators/reduce_ops/reduce_all_op.cu) in benchmark.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:264] [INFO] See https://github.com/PaddlePaddle/Paddle/wiki/PR-CI-OP-benchmark-Manual for details.

2021-04-13 03:41:15 [/workspace/Paddle/tools/test_op_benchmark.sh:265] [INFO] Or you can apply for one RD (Avin0323(Recommend), Xreki, luotao1) approval to pass this PR.

I can approve for PR_CI_OP_Benchmark for missing test script. Please have internel review first, and then I will approve.

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Contributor Author

@luotao1 This PR has passed internal review. It also passed all CI except APPROVAL and OP-benchmark. Could you please start your review?

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 3a804a0 into PaddlePaddle:develop Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants