-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete cudnn6 code #31835
Delete cudnn6 code #31835
Conversation
Thanks for your contribution! |
platform::errors::Unimplemented("Unexpected CUDNN pooling mode.")); | ||
} | ||
} | ||
#else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里把else误删了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,发现了问题
@@ -34,17 +34,6 @@ namespace operators { | |||
static constexpr size_t kNUM_CUDNN_FWD_ALGS = 1; | |||
static constexpr size_t kNUM_CUDNN_BWD_FILTER_ALGS = 1; | |||
static constexpr size_t kNUM_CUDNN_BWD_DATA_ALGS = 1; | |||
#elif CUDNN_VERSION_MIN(6, 0, 5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paddle/paddle/fluid/platform/cudnn_helper.h
Lines 66 to 67 in e787e7f
#define CUDNN_VERSION_MIN(major, minor, patch) \ | |
(CUDNN_VERSION >= ((major)*1000 + (minor)*100 + (patch))) |
CUDNN_VERSION_MIN(6, 0, 5) 表示>=6.0.5,因此37-42行也不能删
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,已经修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 若cudnn6以下不再支持了,其实platform/dynload/cudnn.h的实现可以简化一下,另外是不是代码里面最好加一个对CUDNN_VERSION的静态的assert检查?
@tianshuo78520a 可以在下一个PR里改一下。 |
PR types
Others
PR changes
Others
Describe
Delete cudnn6 code