Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dygraph qat] Use layer to calculate output scale #31861

Merged
merged 6 commits into from
Mar 26, 2021
Merged

[dygraph qat] Use layer to calculate output scale #31861

merged 6 commits into from
Mar 26, 2021

Conversation

juncaipeng
Copy link
Contributor

@juncaipeng juncaipeng commented Mar 25, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Use layer to calculate output scale

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@juncaipeng juncaipeng changed the title [dygraph qat] [WIP] Use layer to calculate output scale [dygraph qat] Use layer to calculate output scale Mar 26, 2021
luotao1
luotao1 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op_function_generator.cc

@juncaipeng juncaipeng merged commit b47478e into PaddlePaddle:develop Mar 26, 2021
@juncaipeng juncaipeng deleted the use_layer_calu_out_scale branch March 26, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfwm2013 gfwm2013 gfwm2013 approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juncaipeng @luotao1 @zhiqiu @gfwm2013