Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the sample codes added by add_sample_code in ops.py #31863

Merged
merged 27 commits into from
Apr 13, 2021

Conversation

wadefelix
Copy link
Contributor

@wadefelix wadefelix commented Mar 25, 2021

PR types

Bug fixes

PR changes

Others

Describe

https://console.cloud.baidu-int.com/devops/icafe/issue/DLTP-23536/show

1 bugfix: the sample codes added py add_sample_code not run in Doc CI, all then are in the file : https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid/layers/ops.py 
2 using argparse in sampcd_processor.py to handle the program parameters.
3 unittests test_sampcd_processor.py for sampcd_processor.py
4 add class Flowers into the wlist_temp_api, IT waste so many times to print the downloaded datasets.

see https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/2585244/job/3605231 , I modified a op's docstring in wadefelix@f0dac63 , triggered successfully.
see https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/2587053/job/3608290 , empty the API_DEV.spec d35fac7 to run all the sample codes. YES, all the sample codes are extracted, but some tests failed for some reason, such as missing enable_static().

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 25, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

Copy link
Contributor

@lelelelelez lelelelelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/test_sampcd_processor.py Show resolved Hide resolved
Copy link
Contributor

@lelelelelez lelelelelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测既然写了,在paddle_build.sh中cpu_py2这条ci里加个逻辑,检测到有人修改这个文件了,就跑一下这个单测。否则这个单测会将成为"历史中的无效代码"。

Copy link
Contributor Author

@wadefelix wadefelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测既然写了,在paddle_build.sh中cpu_py2这条ci里加个逻辑,检测到有人修改这个文件了,就跑一下这个单测。否则这个单测会将成为"历史中的无效代码"。

6d2de97
done, added in the tools/check_file_diff_approvals.sh

tools/test_sampcd_processor.py Show resolved Hide resolved
Copy link
Contributor

@lelelelelez lelelelelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lelelelelez lelelelelez merged commit 4a09c1a into PaddlePaddle:develop Apr 13, 2021
@wadefelix wadefelix deleted the doctest branch April 27, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants