Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uint8 for fill_constant #31911

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

ZzSean
Copy link
Contributor

@ZzSean ZzSean commented Mar 29, 2021

PR types

New features

PR changes

APIs

Describe

Support uint8 for fill_constant

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 29, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@ZzSean ZzSean changed the title Fillconstant uint8 Support uint8 for fill_constant Mar 29, 2021
saxon-zh
saxon-zh previously approved these changes Mar 31, 2021
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -635,7 +635,7 @@ def fill_constant(shape, dtype, value, force_cpu=False, out=None, name=None):
If ``shape`` is a list or tuple, the elements of it should be integers or Tensors with shape [1].
If ``shape`` is an Tensor, it should be an 1-D Tensor with date type int32 or int64.
dtype(np.dtype|str): Data type of the output Tensor which can
be float16, float32, float64, int32, int64.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/paddle/tensor/creation.py里面2.0的接口,oneszerosfull的文档里面也加一下uint8,可以下个PR再加。

@Xreki Xreki merged commit 980227f into PaddlePaddle:develop Apr 1, 2021
@ZzSean ZzSean deleted the fillconstant_uint8 branch April 1, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants