fix matrix_inverse_op with rocm #32128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
reviewed
Apr 9, 2021
| #endif | ||
| #ifdef PADDLE_WITH_HIP | ||
| template <typename T> | ||
| class MatrixInverseFunctor<platform::CUDADeviceContext, T> { |
There was a problem hiding this comment.
和CPU同样的实现，代码不用重复一遍。把Eigen版本作为默认实现就行。
Xreki
approved these changes
Apr 14, 2021
| #include "paddle/fluid/framework/tensor.h" | ||
| #include "paddle/fluid/platform/device_context.h" | ||
|
|
||
| namespace paddle { | ||
| namespace operators { | ||
| namespace math { | ||
|
|
||
| template <typename DeviceContext, typename T> | ||
| void compute_inverse_eigen(const DeviceContext& context, |
There was a problem hiding this comment.
函数命名用AxxBxx这种大小写驼峰式命名，后续PR改下吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
fix matrix_inverse_op with rocm
