Fix some error message #32169
Merged
Fix some error message #32169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Apr 9, 2021
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
There was a problem hiding this comment.
这里scale是个系数吧，应该是要求要大于0，empty的描述不太适合这里，还是用类似之前描述吧，比如The input 'scale' Tensor's value in Operator(interpolate) should be greater than 0, but received value is %d.?
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0 && scale_h > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
There was a problem hiding this comment.
同上，但这里是两个值， 这句建议拆成两句检查，便于用户具体定位是哪个值错了
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0 && scale_h > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0 && scale_h > 0 && scale_d, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0 && scale_h > 0 && scale_d, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
There was a problem hiding this comment.
你好，这里scale_d我不是很理解，scale_d = scale_data[0]，这是一个布尔值吗,我看代码好像应该指深度，这里是不是应该改成scale_d>0,不知道我的理解对不对。
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
| "should be greater than 0.")); | ||
| PADDLE_ENFORCE_EQ(scale_w > 0 && scale_h > 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The scale of interpolate operator are empty.")); |
chenwhql
reviewed
Apr 9, 2021
paddle/fluid/operators/py_func_op.cc
Outdated
| @@ -180,7 +180,7 @@ class PyFuncOpShapeInference : public framework::InferShapeBase { | |||
| void operator()(framework::InferShapeContext *ctx) const override { | |||
| PADDLE_ENFORCE_EQ(!ctx->IsRuntime(), true, | |||
| platform::errors::InvalidArgument( | |||
| "Infer shape cannot be called in runtime.")); | |||
| "Shape inference cannot be called at run time.")); | |||
There was a problem hiding this comment.
这里建议在后面加上 in 'py_func' operator 做限定
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Fix some error message