Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model benchmark ci #32247

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Add model benchmark ci #32247

merged 2 commits into from
Apr 14, 2021

Conversation

xiegegege
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  • 添加运行模型性能测试CI的相关脚本
  • 具体包含编包、准备数据、运行测试脚本等流程

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

luotao1
luotao1 reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在commit信息中加入 test=document_fix 来跳过其他CI

tools/test_model_benchmark.sh Outdated
if [ -d "benchmark_data" ];then
echo -e "benchmark_data exist!"
else
#download data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行注释的可以去掉？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tools/test_model_benchmark.sh

compile_install_paddle
prepare_data
run_model_benchmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paddle/tools/test_op_benchmark.sh

Lines 263 to 266 in 80698ca

if [ $exit_code -ne 0 ]; then
LOG "[INFO] See https://github.com/PaddlePaddle/Paddle/wiki/PR-CI-OP-benchmark-Manual for details."
LOG "[INFO] Or you can apply for one RD (Avin0323(Recommend), Xreki, luotao1) approval to pass this PR."
exit $exit_code

在后续PR里加一个提示语？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，等文档写好了就提PR

luotao1
luotao1 approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 279b653 into PaddlePaddle:develop Apr 14, 2021
@xiegegege xiegegege deleted the add_model_benchmark_ci branch April 14, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiegegege @CLAassistant @luotao1