cpplint code style for *.h and *.cu #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Aug 4, 2017
| Piece(const char* d); | ||
| Piece(const std::string& s); | ||
| Piece(const char* d); // NOLINT | ||
| Piece(const std::string& s); // NOLINT |
There was a problem hiding this comment.
These shouldn't be marked NOLINT but should be fixed by adding the explicit keyword. Let me fix them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exemplifies the advantage of our new building system.
The previous raw CMake to generate each library for each folder, which causes all source code of this library do
cpplintsequentially. In our new building system, eachcc_librarycomposed small piece code, which didcpplintonly depends on its owner target library. Thus, many ofcc_library->cpplintcan run simultaneously.