[oneDNN] Made cache to be stored in TLS for prediction #32309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
@luotao1 My PR is failing on couple of CI runs. It is probably related to my PR, but I cannot see anything in logs. Could you please advice on PR-CI_inference . Why does it fail ? (I have restarted 4 times) |
|
There may be something wrong with our CI, could you update your code to develop branch? @jczaja @lidanqing-intel |
|
@jczaja @lidanqing-intel Please do not update this PR, we will have a debug for CI with this PR. You can create a new PR at the same time. Thanks very much! |
|
@jczaja Hi could this PR be closed. Luotao said they have fixed inference CI |
|
@lidanqing-intel Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
This is second fix to #31992. It does make oneDNN cache to be optionally stored to Thread Local storage location. It is enabled for prediction.