Added bilinear and nearest interp v2 oneDNN FP32 kernels #32312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
@lidanqing-intel @jczaja @wozna Could you please review this PR? |
| auto scale_data = get_new_data_from_tensor<float>(scale_tensor); | ||
| std::copy(scale_data.begin(), scale_data.end(), scales.begin()); | ||
| while (scale_data.size() < 3) scales.push_back(scale_data[0]); | ||
| } else { |
There was a problem hiding this comment.
Hi, Is this else branch only part that is different from interpolate_mkldnn_v1?
Maybe function std::is_same for type comparison could be used for this case and we could combine interpolate v1 and v2?
| @@ -0,0 +1,210 @@ | |||
| # Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | |||
|
LGTM |
jczaja
approved these changes
Apr 20, 2021
luotao1
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Added oneDNN FP32 kernels for nearest_interp_v2 and bilinear_interp_v2