Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let paddle.utils.install_check support CPU package with GPU device #32428

Merged
merged 3 commits into from
Apr 25, 2021

Conversation

pangyoki
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

  • logic problem in checking

In original paddle.utils.install_check, if users install the CPU package on the GPU device, PADDLE will check the installation using GPU logic.
This PR fixes this problem. If the user installs the CPU package, it will only check whether it can be performed well on the CPU.

  • add checking in dygraph mode

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -74,6 +74,30 @@ def _is_cuda_available():
return False


def _run_dygraph_single(use_cuda):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_cuda is not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangyoki pangyoki merged commit 06276f4 into PaddlePaddle:develop Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants