Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global linker and exe from mkldnn iomp #3244

Merged
merged 3 commits into from
Aug 7, 2017

Conversation

tensor-tang
Copy link
Contributor

fix #3232

@luotao1
Copy link
Contributor

luotao1 commented Aug 4, 2017

需要打开AVX_FOUND开关来测一下把

@tensor-tang
Copy link
Contributor Author

tensor-tang commented Aug 4, 2017

@luotao1 我已经打开了

第一个PR_CI没过,是因为在最后一个test的时候timeout了。

105/106 Test 106: test_framework ...................... Passed 296.82 sec
[12:56:42][Step 1/1] The build Paddle::PR_CI 2032 {buildId=4536} has been running for more than 60 minutes. Terminating...
[12:56:42][Step 1/1] Execution timeout

另外我在本地按照 @reyoung 的方式测试了,没有问题了。

@tensor-tang
Copy link
Contributor Author

还是在最后一个test的时候timeout了

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensor-tang
Copy link
Contributor Author

备注下:
这里去除掉MKLDNN中的iomp link,仅仅是去除了全局link和exe。
并不会影响MKLDNN的使用,在同时打开MKLDNN和MKLML的时候,会把这个iomp link到EXTERNAL_LIBS,所以不会影响MKLDNN。

@luotao1 luotao1 merged commit fd64369 into PaddlePaddle:develop Aug 7, 2017
@tensor-tang tensor-tang deleted the issue3232 branch August 7, 2017 06:53
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
* updatee pretrain match

* update match for rcnn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MKLDNN changes global linker flags with shared library.
2 participants