Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Add nan& inf check FLAG for dygraph #32635

Merged

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Apr 28, 2021

PR types

New features

PR changes

Others

Describe

[Debug] Add nan& inf check FLAG for dygraph

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 6, 2021

Sorry to inform you that 4d5beb8's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@chenwhql chenwhql requested review from wangxicoding, JiabinYang and zhiqiu and removed request for wangxicoding June 8, 2021 06:46
@chenwhql chenwhql changed the title [Debug] Add check nan& inf for fygraph [Debug] Add nan& inf check FLAG for fygraph Jun 8, 2021
@chenwhql chenwhql changed the title [Debug] Add nan& inf check FLAG for fygraph [Debug] Add nan& inf check FLAG for dygraph Jun 8, 2021
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

template <typename VarType>
void CheckOpHasNanOrInfInDygraph(const std::string& op_type,
const imperative::NameVarMap<VarType>& op_outs,
platform::Place place) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过这个没有过滤op、var的功能了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦是的,那我再补充一下

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先合入再补充也行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

经讨论,后续有需求再补充

@chenwhql chenwhql merged commit df4a978 into PaddlePaddle:develop Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants