Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle-TRT]fix trt-converter-fc_op #32671

Merged
merged 10 commits into from
May 8, 2021
Merged

Conversation

Wangzheee
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

重写converter的fc_op,能支持动态、静态、int8输入,增加单测的情况

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cryoco cryoco requested review from shangzhizhou and cryoco and removed request for shangzhizhou April 29, 2021 04:14
Comment on lines 63 to 67
PADDLE_ENFORCE_GE(x_num_col_dims, 1,
platform::errors::InvalidArgument(
"converter expects x_num_col_dims >= 1, but "
"x_num_col_dims = %d.",
x_num_col_dims));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个检查放到op_teller里吧

Copy link
Contributor

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit 62d848d into PaddlePaddle:develop May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants